-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: polish release doc #2531
Merged
Merged
doc: polish release doc #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
suyanhanx
commented
Jun 25, 2023
•
edited
Loading
edited
- Fix some typos.
- Add a verify-a-release-candidate doc.
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
suyanhanx
requested review from
Xuanwo,
PsiACE,
ClSlaid and
sundy-li
as code owners
June 25, 2023 09:51
Xuanwo
reviewed
Jun 25, 2023
Co-authored-by: Xuanwo <github@xuanwo.io>
This reverts commit 722fd2d.
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
…o polish-release-doc Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Xuanwo
reviewed
Jun 25, 2023
website/docs/contributing/reference/verify_a_release_candidate.md
Outdated
Show resolved
Hide resolved
Xuanwo
reviewed
Jun 26, 2023
website/docs/contributing/reference/verify_a_release_candidate.md
Outdated
Show resolved
Hide resolved
Xuanwo
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.